Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bvhcast #595

Merged
merged 15 commits into from
Oct 6, 2023
Merged

Update bvhcast #595

merged 15 commits into from
Oct 6, 2023

Conversation

gkjohnson
Copy link
Owner

@gkjohnson gkjohnson commented Oct 6, 2023

Fix #257

Add new bvhcast implementation

TODO

  • Test performance (it's slower)
  • Get the number of triangle tests to be identical
  • Get the number of matrix applications to be lower / the same
  • Can we effectively reproduce what's happening in the original shapecast approach but with some optimizations if we perform it manually?
  • GC improvement
  • More performance improvements, optimization
  • Get the number of bounds traversed lower
  • Check bounds in more places
  • Ensure correctness (drag position all the way up, revert to prior commits) (broke in a31cb89)

@gkjohnson gkjohnson merged commit 2994d47 into master Oct 6, 2023
@gkjohnson gkjohnson deleted the update-bvhcast branch October 6, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide utility function for comparing bounds / tris down two BVH trees
1 participant