Support multiple email addresses in mailto

gjtorikian · Apr 18, 2023 · 0e3d881 · 0e3d881
1 parent bcc4bac
commit 0e3d881
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/lib/html_proofer/check/links.rb b/lib/html_proofer/check/links.rb
@@ -96,7 +96,8 @@ def handle_mailto
             "#{@link.url.raw_attribute} contains no email address",
             element: @link,
           ) unless ignore_empty_mailto?
-        elsif !/#{URI::MailTo::EMAIL_REGEXP}/o.match?(@link.url.path)
+        # eg., if any do not match a valid URL
+        elsif @link.url.path.split(",").any? { |email| !/#{URI::MailTo::EMAIL_REGEXP}/o.match?(email) }
           add_failure(
             "#{@link.url.raw_attribute} contains an invalid email address",
             element: @link,

diff --git a/spec/html-proofer/fixtures/links/multiple_mailto_links.html b/spec/html-proofer/fixtures/links/multiple_mailto_links.html
@@ -0,0 +1,5 @@
+<html>
+  <body>
+    <a href="mailto:[email protected],[email protected],[email protected]">Mail me</a>.
+  </body>
+</html>
diff --git a/spec/html-proofer/links_spec.rb b/spec/html-proofer/links_spec.rb
@@ -246,6 +246,12 @@
     expect(proofer.failed_checks).to(eq([]))
   end
 
+  it "accepts multiple mailto links" do
+    ignorable_links = File.join(FIXTURES_DIR, "links", "multiple_mailto_links.html")
+    proofer = run_proofer(ignorable_links, :file)
+    expect(proofer.failed_checks).to(eq([]))
+  end
+
   it "ignores blank mailto links when configured to allow them" do
     blank_mail_to_link = File.join(FIXTURES_DIR, "links", "blank_mailto_link.html")
     proofer = run_proofer(blank_mail_to_link, :file, ignore_empty_mailto: true)