Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGI.escape emoji name #92

Merged
merged 1 commit into from
Nov 20, 2013
Merged

CGI.escape emoji name #92

merged 1 commit into from
Nov 20, 2013

Conversation

jayroh
Copy link
Contributor

@jayroh jayroh commented Nov 19, 2013

The commonly used +1, when located somewhere like S3, will not work
as the + is not escaped, causing the browser to think it's a space
instead of a literal +. To replicate, upload +1.png to S3 and try to
bring it up in Chrome.

This commit escapes the emoji name before returning the img tag.

@jch
Copy link
Contributor

jch commented Nov 20, 2013

Sounds reasonable. Could you take a look at the build failures?

@jayroh
Copy link
Contributor Author

jayroh commented Nov 20, 2013

Hey Jerry - Yeah I'm looking into them right now. Seems that the CGI isn't
being required up on Travis but, oddly enough, pass locally. I'll get it
situated today for final review.

On Wed, Nov 20, 2013 at 10:23 AM, Jerry Cheung [email protected]:

Sounds reasonable. Could you take a look at the build failures?


Reply to this email directly or view it on GitHubhttps://github.com//pull/92#issuecomment-28897685
.

The commonly used `+1`, when located somewhere like S3, will not work
as the + is not escaped, causing the browser to think it's a space
instead of a literal `+`. To replicate, upload +1.png to S3 and try to
bring it up in Chrome.

This commit escapes the emoji name before returning the img tag.
@jayroh
Copy link
Contributor Author

jayroh commented Nov 20, 2013

Ha - hadn't taken the older ruby versions into consideration, so that's why.

@jch we're back to green across the board at Travis. Also squashed and force pushed my branch.

jch added a commit that referenced this pull request Nov 20, 2013
@jch jch merged commit 15c549c into gjtorikian:master Nov 20, 2013
@jch
Copy link
Contributor

jch commented Nov 20, 2013

👍 awesome, thanks for the pull! Release coming soon.

@jayroh
Copy link
Contributor Author

jayroh commented Nov 20, 2013

🎉 Wooo! Thanks :)

On Wed, Nov 20, 2013 at 1:28 PM, Jerry Cheung [email protected]:

[image: 👍] awesome, thanks for the pull! Release coming soon.


Reply to this email directly or view it on GitHubhttps://github.com//pull/92#issuecomment-28915009
.

@jch jch mentioned this pull request Nov 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants