Ensure required context values are present #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Raise an ArgumentError if the asset_root isn't provided.
|
You can see this approach elsewhere here https://github.com/github/github-html/blob/master/lib/html/pipeline/camo_filter.rb#L49 |
atmos
added a commit
that referenced
this pull request
Oct 3, 2012
Ensure required context values are present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I failed to provide an asset_host for EmojiFilter, the error thrown was a vague
can't convert nil into String.I followed CamoFilter's example of raising an exception if the required value isn't provided, but I made it an ArgumentError.
However this is handled, it should probably be handled the same way across all the filters that require certain context values.