Add link_attr option to Autolink filter #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +15,11 @@ def test_autolink_option | |||
| AutolinkFilter.to_html('<p>"http://www.github.com"</p>', :autolink => false) | |||
| end | |||
|
|
|||
| def test_autolink_link_attr | |||
| assert_equal '<p>"<a href="http://www.github.com" target="_blank">http://www.github.com</a>"</p>', | |||
| AutolinkFilter.to_html('<p>"http://www.github.com"</p>', :link_attr => 'target="_blank"') | |||
There was a problem hiding this comment.
Feels strange to pass in the actual HTML string here. How would one pass in multiple link attributes?
Is it possible to have a hash syntax like:
AutolinkFilter.to_html '<p>"http://www.github.com"</p>',
:link_attr => { :target => "_blank", :data_foo => "bar"}
|
👍 good idea |
|
I felt the same way but this is actually how Rinku works according to the
|
|
Works for me. If you're using Rinku, then you're already used to the syntax. |
jch
added a commit
that referenced
this pull request
Oct 22, 2013
Add link_attr option to Autolink filter
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's you add things like
target="_blank"to links if you want to through thelink_attroption just like Rinku allows.