-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filters Manage Dependencies #80
Filters Manage Dependencies #80
Commits on Aug 25, 2013
-
* Add dependency management test cases for each `Filter` with a dependency * Add `assert_dependency_management_error` custom assertion which asserts a custom exception and message are raised if a dependency is missing * Move all `Filter` dependencies to `Gemfile` `:test` block for test cases and CI * Implement `TestingDependency` helper to abstract unloading and loading `Gemfile` `:test` block gems when asserting dependency management errors * Implement `MissingDependencyException` custom exception with `MESSAGE` constant as a format string, so each `Filter` raises a uniform exception * Add `begin..rescue..end` blocks around each `Filter` `require` statement to raise a `MissingDependencyException` when a gem can not be loaded * Update README.md detailing new dependency management with listing of `Filter` gem dependencies * Add gemspec post install message to inform users their apps must bundle `Filter` dependencies
Simeon F. Willbanks committedAug 25, 2013 1Configuration menu - View commit details
-
Copy full SHA for d3fc6d9 - Browse repository at this point
Copy the full SHA d3fc6d9View commit details
Commits on Aug 28, 2013
-
Address Pull Request comments:
* Copy edit README.md * In gemspec, link README.md dependencies and update post install message * Rename test helper to `assert_dependency` * Remove `TestingDependency` in favor of stubbing `Kernal#require`
Simeon F. Willbanks committedAug 28, 2013 Configuration menu - View commit details
-
Copy full SHA for c25c890 - Browse repository at this point
Copy the full SHA c25c890View commit details -
Textile Filter does require RedCloth
Simeon F. Willbanks committedAug 28, 2013 Configuration menu - View commit details
-
Copy full SHA for f0983dc - Browse repository at this point
Copy the full SHA f0983dcView commit details -
Move ActiveSupport::XmlMini_Nokogiri to test helper, since its mixed …
…in #to_hash is only used by #assert_equal_html
Simeon F. Willbanks committedAug 28, 2013 Configuration menu - View commit details
-
Copy full SHA for f9c6d06 - Browse repository at this point
Copy the full SHA f9c6d06View commit details
Commits on Sep 23, 2013
-
Merge upstream/master; activesupport is a full dependency
Simeon F. Willbanks committedSep 23, 2013 Configuration menu - View commit details
-
Copy full SHA for e042c3e - Browse repository at this point
Copy the full SHA e042c3eView commit details
Commits on Oct 23, 2013
-
Simeon F. Willbanks committed
Oct 23, 2013 Configuration menu - View commit details
-
Copy full SHA for 0471de4 - Browse repository at this point
Copy the full SHA 0471de4View commit details -
Merge remote-tracking branch 'upstream/master' into simple-dependency…
…-management
Simeon F. Willbanks committedOct 23, 2013 Configuration menu - View commit details
-
Copy full SHA for 3801fd5 - Browse repository at this point
Copy the full SHA 3801fd5View commit details -
Don't test dependency management since its testing require and is bri…
…ttle
Simeon F. Willbanks committedOct 23, 2013 Configuration menu - View commit details
-
Copy full SHA for 154ef94 - Browse repository at this point
Copy the full SHA 154ef94View commit details -
No need for MissingDependencyException
Simeon F. Willbanks committedOct 23, 2013 Configuration menu - View commit details
-
Copy full SHA for 6ff25ad - Browse repository at this point
Copy the full SHA 6ff25adView commit details -
If a dependency is missing, exit with a 1 status and write help messa…
…ge to STDERR.
Simeon F. Willbanks committedOct 23, 2013 Configuration menu - View commit details
-
Copy full SHA for a0acb69 - Browse repository at this point
Copy the full SHA a0acb69View commit details