Allow passing skip_tags in autolink filter context #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables passing the `skip_tags` argument to Rinku. Defaults to Rinku.skip_tags
|
Looks good. I can cut a release with these changes, but since it changes the default behavior, you'll need to update any pipelines that use this before upgrading the gem. |
|
It should be backwards compatible. The previously hardcoded defaults are the same as if you don't pass
|
|
Nice, was on my phone and missed the test you added for that case. |
jch
added a commit
that referenced
this pull request
Jul 10, 2013
Allow passing skip_tags in autolink filter context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables passing the
skip_tagsargument to Rinku. Defaults toRinku.skip_tags.