Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #54 allow table section elements (thead, tfoot, tbody) #55

Merged
merged 1 commit into from
Jul 3, 2013

Conversation

mojavelinux
Copy link
Contributor

No description provided.

@rtomayko
Copy link
Contributor

👍

@suntong
Copy link

suntong commented Jun 16, 2013

wonderful. thanks.

@jch
Copy link
Contributor

jch commented Jul 2, 2013

Thanks for opening this pull! I'm not aware of all the security implications of whitelisting these elements, so I'm grabbing a second opinion before I merge. It looks sane to me though.

@mojavelinux
Copy link
Contributor Author

Great. I look forward to it.

Keep in mind, though, that was careful to disallow the thead/tbody/tfoot in the same places where rows are not allowed. The browser implicitly adds tbody anyway when you don't have one of the three.

Let me know if you need any additional input from me. Thanks!

@btoews
Copy link

btoews commented Jul 3, 2013

👍

jch added a commit that referenced this pull request Jul 3, 2013
resolves #54 allow table section elements (thead, tfoot, tbody)
@jch jch merged commit 60b8b85 into gjtorikian:master Jul 3, 2013
@jch
Copy link
Contributor

jch commented Jul 3, 2013

Thanks all!

@mojavelinux
Copy link
Contributor Author

🍻

@mojavelinux mojavelinux deleted the table-sections branch July 3, 2013 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants