-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument filters in the pipeline #45
Conversation
How about adding an HTML::Pipeline.default_instrumentation_service = SomeService.new |
@jch 👓 |
Hawt. Add a blurb about this in the readme? |
@jch now that I write the README, does it make sense to instrument the whole pipeline call, too? That would fire off a |
👍 adding an instrument to the pipeline call. I like that it gives you a quick total for all the filters. Thanks for the extra readme cleanup too. |
niiice |
@jch boom. Whatcha think? |
Instrument filters in the pipeline
🤘 perfect sir. I'll cut a release after ci passes |
This makes
HTML::Pipeline
compatible with ActiveSupport::Notifications instrumentation.Shuffles things around a bit but adds instrumenting to every filter call.
@jch I know we talked about putting the instrumentation on the individual filters but I decided to keep it here since I wanted to make it easy to make the instrumentation service object available. The pipeline felt like the right place to put that, and the individual filter wasn't aware of the pipeline object as far as I could see.