Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add result[:mentioned_usernames] for MentionFilter #42

Merged
merged 1 commit into from
Mar 5, 2013

Conversation

fahchen
Copy link
Contributor

@fahchen fahchen commented Mar 5, 2013

MarkdownPipeline = HTML::Pipeline.new [
  HTML::Pipeline::MarkdownFilter,
  HTML::Pipeline::MentionFilter
]

body = '@fahchen @test'
result = MarkdownPipeline.call(body)
result[:mentioned_usernames] # => ['fahchen', 'test']

no_result_body = 'hello world'
no_result = MarkdownPipeline.call(no_result_body)
no_result[:mentioned_usernames] # => []

useful to send notification to mentioned_usernames

@jch
Copy link
Contributor

jch commented Mar 5, 2013

Looks good to me. I'll look into why the build's failing on ruby 1.8.

jch added a commit that referenced this pull request Mar 5, 2013
add result[:mentioned_usernames] for MentionFilter
@jch jch merged commit 696ba4d into gjtorikian:master Mar 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants