Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle odd numbers of NodeFilters to be configured #389

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Handle odd numbers of NodeFilters to be configured #389

merged 3 commits into from
Dec 28, 2023

Commits on Dec 28, 2023

  1. Handle odd numbers of NodeFilters to be configured 

    The previous method of merging the results from the NodeFilter instances was breaking because Ruby was treating it as a series of 2-element arrays.

If you had 0, 1 or 2 node filters configured, it would work fine; if you added a third, it would break with an `ArgumentError`. Adding a fourth makes it work again.

Fixes gjtorikian#388
    @stevehill1981
    stevehill1981 authored Dec 28, 2023
    Configuration menu
    Copy the full SHA
    14abefb View commit details
    Browse the repository at this point in the history

  2. Actually keep the results

    @stevehill1981
    stevehill1981 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    a8fdac9 View commit details
    Browse the repository at this point in the history

  3. :gem 3.0.1

    @gjtorikian
    gjtorikian committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    74ef050 View commit details
    Browse the repository at this point in the history