Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the AssetProxyFilter #379

Merged
merged 6 commits into from
Jun 5, 2023
Merged

Add the AssetProxyFilter #379

merged 6 commits into from
Jun 5, 2023

Conversation

digitalmoksha
Copy link
Contributor

Adds a NodeFilter called AssetProxyFilter, which is based on the original CamoFilter

@digitalmoksha
Copy link
Contributor Author

@gjtorikian here is a close version of our AssetProxyFilter. Take a look and let me know if there is anything else I need to add.

@digitalmoksha
Copy link
Contributor Author

I'm also fine and will make the change if you want to keep the original CamoFilter name, this was just the easiest in the moment.

@gjtorikian
Copy link
Owner

Thank you so much for this, and the test. No need to worry about anything else, I'll cleanup as needed!

OOC, if I am understanding correctly, some other process still uploads the image to the proxy server, yeah?

@digitalmoksha
Copy link
Contributor Author

No need to worry about anything else, I'll cleanup as needed!

Great, thanks.

Nothing needs to get uploaded to the proxy server. It actually takes the encoded url and makes the request to the real http server, and passes the data back to the client browser. It’s there just so the user’s IP address is not exposed. There is no caching involved. It can impose limits, such as size.

@digitalmoksha digitalmoksha mentioned this pull request May 20, 2023
@gjtorikian
Copy link
Owner

Oh! I see now, sorry—for some reason I thought this was doing something else. Thanks again!

@gjtorikian gjtorikian merged commit 63cbcfd into gjtorikian:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants