Migrate from Nokogiri to Selma #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjtorikian
force-pushed
the
selma-migration
branch
from
94ca27f
to
9626d70
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes one of the blocking items for a v3 release: migrating to Selma. Selma's process for parsing html uses lol-html, a Rust library, as its underlying mechanism. It operates purely on CSS selectors, and has a few advantages over the current Nokogiri based mechanism. Namely, in the current systen, text is parsed over multiple times. Each NodeFilter runs its set of CSS selectors synchronously. lol-html, on the other hand, parses the text once, compiles its CSS selectors, and more efficiently allows for text manipulation.