Replace EscapeUtils.escape_html with CGI.escape_html #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EscapeUtils.escape_html was deprecated in 0da0c0a80017a18b2e007921782e83c8b94e6c41 and later removed. Regarding drop if / escape please see 0da0c0a80017a18b2e007921782e83c8b94e6c41: “there's no reason to escape for slashes `/` in 2022.” This commit makes the test suite green again.
|
Cool. Thank you! |
|
Thank you @gjtorikian for the quick merge! :) |
|
Would it be possible to get a new gem release cut in the 2.x series with this change included? It'll help address these deprecation warnings when using the gem: |
brettchalupa
added a commit
to brettchalupa/graphql-docs
that referenced
this pull request
Oct 14, 2022
… being deprecated It can be removed once gjtorikian/html-pipeline#365 is released in a gem. It may be possible to remove escape_utils at that point too. Temporarily relieves this warning: ``` EscapeUtils.escape_html is deprecated. Use GCI.escapeHTML instead, it's faster ```
|
Sure, 2.14.3 has been released with this change. |
|
@gjtorikian Thanks! |
brettchalupa
added a commit
to brettchalupa/graphql-docs
that referenced
this pull request
Oct 14, 2022
``` EscapeUtils.escape_html is deprecated. Use GCI.escapeHTML instead, it's faster ``` v2.14.3 has a fix to address that warning, so we want that as the minimum version so people don't see that when generating their docs. See gjtorikian/html-pipeline#365 for reference. Remove stricter pinning of `escape_utils` since we can use newer version.
brettchalupa
added a commit
to brettchalupa/graphql-docs
that referenced
this pull request
Oct 14, 2022
``` EscapeUtils.escape_html is deprecated. Use GCI.escapeHTML instead, it's faster ``` v2.14.3 has a fix to address that warning, so we want that as the minimum version so people don't see that when generating their docs. See gjtorikian/html-pipeline#365 for reference. Remove stricter pinning of `escape_utils` since we can use newer version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EscapeUtils.escape_htmlwas deprecated in brianmario/escape_utils@0da0c0a and later removed.Regarding drop of
/escape please see the above commit: “there's no reason to escape for slashes/in 2022.”This commit makes the test suite green again.