Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split filters up #360

Merged
merged 10 commits into from
Jun 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,26 +15,27 @@ jobs:
fail-fast: true
matrix:
ruby-version:
- 3.1.0
- 3.0.0
- 2.7.2
- 2.6.6
- 2.5.8
- truffleruby-head
experimental: [false]
include:
- ruby-version: head
experimental: true
- ruby-head

continue-on-error: ${{ matrix.experimental }}

steps:
- uses: actions/checkout@v2
- run: sudo apt-get -yqq install libxml2-dev libxslt-dev
if: startsWith(matrix.ruby-version, 'truffleruby')

- name: Install libxslt and libxml2
run: sudo apt-get install libxslt-dev libxml2-dev

- name: Set up Ruby ${{ matrix.ruby-version }}
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true

- name: Install dependencies
run: bundle install

- name: Run tests
run: bundle exec rake
continue-on-error: ${{ matrix.ruby == 'ruby-head' }}
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@

## 2.8.4

* Freeze all elements in HTML::Pipeline::SanitizationFilter [#299](https://github.com/jch/html-pipeline/pull/299)
* Freeze all elements in HTMLPipeline::SanitizationFilter [#299](https://github.com/jch/html-pipeline/pull/299)

## 2.8.3

Expand Down
16 changes: 8 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
# Contributing

Thanks for using and improving `HTML::Pipeline`!
Thanks for using and improving `HTMLPipeline`!

- [Submitting a New Issue](#submitting-a-new-issue)
- [Sending a Pull Request](#sending-a-pull-request)

## Submitting a New Issue

If there's an idea you'd like to propose, or a design change, feel free to file a new issue.
If there's an idea you'd like to propose, or a design change, feel free to file a new issue.

If you have an implementation question or believe you've found a bug, please provide as many details as possible:

- Input document
- Output HTML document
- the exact `HTML::Pipeline` code you are using
- the exact `HTMLPipeline` code you are using
- output of the following from your project

```
Expand Down Expand Up @@ -41,17 +41,17 @@ To run a specific test file:

To run a specific test:

`bundle exec ruby -Itest test/html/pipeline/markdown_filter_test.rb -n test_disabling_gfm`
`bundle exec ruby -Itest test/html/pipeline/markdown_filter_test.rb -n test_disabling_gfm`

To run the full suite with all [supported rubies][travisyaml] in bash:

```bash
rubies=(ree-1.8.7-2011.03 1.9.2-p290 1.9.3-p429 2.0.0-p247)
for r in ${rubies[*]}
do
for r in ${rubies[*]}
do
rbenv local $r # switch to your version manager of choice
bundle install
bundle exec rake
bundle install
bundle exec rake
done
```

Expand Down
31 changes: 15 additions & 16 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,30 +1,29 @@
# frozen_string_literal: true

source 'https://rubygems.org'
source "https://rubygems.org"

# Specify your gem's dependencies in html-pipeline.gemspec
gemspec

gem 'awesome_print'
gem "awesome_print"

gem 'rubocop'
gem 'rubocop-performance'
gem 'rubocop-standard'
gem "rubocop"
gem "rubocop-standard"

group :development do
gem 'bundler'
gem 'rake'
gem "bundler"
gem "rake"
end

group :test do
gem 'commonmarker', '~> 0.16', require: false
gem 'gemoji', '~> 3.0', require: false
gem 'gemojione', '~> 4.3', require: false
gem 'minitest'
gem 'rinku', '~> 1.7', require: false
gem 'sanitize', '~> 5.2', require: false
gem "commonmarker", "~> 0.16", require: false
gem "gemoji", "~> 3.0", require: false
gem "gemojione", "~> 4.3", require: false
gem "minitest"
gem "rinku", "~> 1.7", require: false
gem "sanitize", "~> 5.2", require: false

gem 'escape_utils', '~> 1.0', require: false
gem 'minitest-focus', '~> 1.1'
gem 'rouge', '~> 3.1', require: false
gem "escape_utils", "~> 1.0", require: false
gem "minitest-focus", "~> 1.1"
gem "rouge", "~> 3.1", require: false
end
4 changes: 2 additions & 2 deletions LICENSE → LICENSE.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (c) 2012 GitHub Inc. and Jerry Cheung
Copyright (c) 2022 Garen Torikian

MIT License

Expand All @@ -19,4 +19,4 @@ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Loading