Switch to GitHub Actions #346
Conversation
gjtorikian
force-pushed
the
migrate-to-gh-actions
branch
from
bdcc07a
to
1d31f83
Compare
|
@gogainda It seems that |
|
@eregon I just double checked nokoigiri locally, it's installing correctly. Not sure why it's failing in GitHub Actions |
|
See the workflow step in oracle/truffleruby#62 (comment) |
| - name: Install dependencies | ||
| run: | | ||
| bundle config set --local path '../../vendor/bundle' | ||
| bundle install |
There was a problem hiding this comment.
This whole step seems unneeded, and setting the path will most likely breaks bundler caching, see https://github.com/ruby/setup-ruby/#caching-bundle-install-automatically
| with: | ||
| ruby-version: 3.0 | ||
| bundler-cache: true | ||
| - run: bundle install |
There was a problem hiding this comment.
redundant with bundler-cache: true above
|
@eregon thanks, I will open a new PR to fix it |
No description provided.