Ensure <pre> nodes are not removed after syntax highlighting #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading to rouge, I noticed the syntax highlighting in `octodown` has disappeared. It seems that the `pre` tags were being removed, which are neccesary for correct highlighting with rouge. This commit fixes this by replacing the `inner_html` of the preblock with the code highlighted by rouge.
ianks
commented
May 4, 2018
| @@ -10,7 +10,7 @@ group :development do | |||
| end | |||
|
|
|||
| group :test do | |||
| gem 'commonmarker', '~> 0.14', require: false | |||
| gem 'commonmarker', '~> 0.16', require: false | |||
There was a problem hiding this comment.
Bumped because :GITHUB_PRE_LANG was not introduced until 0.16.1
ianks
commented
May 4, 2018
| @@ -9,6 +9,7 @@ Rake::TestTask.new do |t| | |||
| t.libs << 'test' | |||
| t.test_files = FileList['test/**/*_test.rb'] | |||
| t.verbose = true | |||
| t.warning = false | |||
There was a problem hiding this comment.
Rouge is spitting out a ton of warnings which made the test output a bit annoying, so I added this flag.
ianks
commented
May 4, 2018
| klass = node['class'] | ||
| klass = [klass, "highlight-#{lang}"].compact.join ' ' | ||
| scope = context[:scope] || "highlight-#{lang}" |
There was a problem hiding this comment.
I would like to be able to scope my css, so I added this option.
For more info, https://github.com/jneen/rouge#scope-highlight
|
Looks great! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to rouge, I noticed the syntax highlighting in
octodownhasdisappeared. It seems that the
pretags were being removed, which areneccesary for correct highlighting with rouge. This commit fixes this by
replacing the
inner_htmlof the preblock with the code highlighted by rouge.