Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce travis errors and move to trusty #285

Merged
merged 3 commits into from
Sep 20, 2017

Conversation

timdiggins
Copy link
Contributor

This is a replacement to #283 which:

  • brings travis to trusty (with sudo: false it results in travis throwing away source: libicu-dev, but everything seems to install and run ok, so maybe that source is no longer needed on trusty?)
  • improves reliability of bundle install on travis by deleting the .lock files for specific gemfiles and overriding/removing the --deployment option to bundler so that bundler will never complain about the gemfile.lock being updated, and will always use latest dependencies (similar to a current clean install on any system)

@gjtorikian
Copy link
Owner

Given that e27f50a passed, why is dist: trusty necessary?

@timdiggins
Copy link
Contributor Author

Given that e27f50a passed, why is dist: trusty necessary?

@gjtorikian because travis is moving its default from precise to trusty anytime now, I thought it would be better to be specific (rather than just wait for it possibly to fail). True, it has now succeeded so could just wait for the automatic default to change, but I think the more predictability in CI the better

@gjtorikian
Copy link
Owner

but I think the more predictability in CI the better

My concern is that we will forget to remove or change this value when Travis inevitable moves off of trusty and onto The Next Great Thing, leaving us stuck in the past.

Given that this PR works with the current Travis setup and the future Travis setup I'm going to go ahead and merge it but take that line out.

@gjtorikian gjtorikian merged commit 616dc20 into gjtorikian:master Sep 20, 2017
@gjtorikian
Copy link
Owner

Thank you!

@timdiggins timdiggins deleted the more-travis branch September 21, 2017 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants