Let users set the common marker extensions #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kivikakk
reviewed
Aug 16, 2017
lib/html/pipeline/markdown_filter.rb
Outdated
| @@ -12,6 +12,8 @@ class Pipeline | |||
| # | |||
| # Context options: | |||
| # :gfm => false Disable GFM line-end processing | |||
| # :commonmarker_extensions => [ ] Common marker extensions to | |||
There was a problem hiding this comment.
What's the [ ] doing here? I think this is meant to suggest the default, which is instead written on the next line.
There was a problem hiding this comment.
Common marker => CommonMarker
| assert_equal(doc, iframe_escaped) | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
One too many blank lines.
|
Wow, the failures sure are extensive. I'm guessing a recent merge updated |
|
➡️ #280 |
|
Can you pull in |
thejandroman
force-pushed
the
cg-config-commonmarker-extensions
branch
from
2fc7d41
to
2cb3b0d
Compare
Changes: - Expose the common marker extensions to the context. - Set a default list of ext. - Update docs.
thejandroman
force-pushed
the
cg-config-commonmarker-extensions
branch
from
2cb3b0d
to
dc0f98a
Compare
|
@kivikakk @gjtorikian This should be ready for a re-review. |
|
Looks good to me! |
|
Released as 2.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: