Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to CommonMark #274

Merged
merged 3 commits into from
May 23, 2017
Merged

Switch to CommonMark #274

merged 3 commits into from
May 23, 2017

Conversation

kivikakk
Copy link
Contributor

github-markdown has been long deprecated, and now that we're using commonmarker in prod at GitHub everywhere we used to use github-markdown, this seems like an appropriate switch.

@kivikakk
Copy link
Contributor Author

Fixing the build while I'm here!

Copy link
Contributor

@JuanitoFatas JuanitoFatas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holden
Copy link

holden commented May 17, 2017

Can this awesomeness get merged? (github markdown hasn't had an update since Aug 2015!)

@gjtorikian
Copy link
Owner

I just got commit access and also want this. 😁 💃

@gjtorikian gjtorikian merged commit 127c395 into gjtorikian:master May 23, 2017
@kivikakk
Copy link
Contributor Author

:D Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants