Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.4 #268

Merged
merged 4 commits into from
Jan 13, 2017
Merged

Ruby 2.4 #268

merged 4 commits into from
Jan 13, 2017

Conversation

haileys
Copy link
Contributor

@haileys haileys commented Jan 12, 2017

This pull request adds Ruby 2.4 support to html-pipeline.

Charlie Somerville added 2 commits January 12, 2017 15:04
Starting in Ruby 2.4, the String case conversion methods are Unicode
aware. To ensure that anchors in TOC links remain stable when upgrading
to Ruby 2.4, we need to preserve the old behaviour by passing :ascii
to String#downcase
Charlie Somerville added 2 commits January 12, 2017 16:28
github-linguist 2.12.0 depends on an old version of pygments.rb which
depends on an old version of yajl-ruby which does not compile on ruby 2.4
@JuanitoFatas
Copy link
Contributor

JuanitoFatas commented Jan 12, 2017

👍

json and ruby 2.4 related issue: ruby/json#303

When Rails 4.2.8 release, it can build with Ruby 2.4

@jch jch merged commit ca2c478 into gjtorikian:master Jan 13, 2017
@haileys haileys deleted the ruby-2.4 branch January 16, 2017 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants