Use entire namespace so exception constant is resolved

[simeonwillbanks]

Problem

#241 introduced a custom exception, but it used the exception outside the HTML::Pipeline namespace.

~/Code/html-pipeline master
❯ irb -I lib
[1] pry(main)> require 'html/pipeline'
=> true
[2] pry(main)> filter = HTML::Pipeline::MarkdownFilter.new("Hi **world**!")
NameError: uninitialized constant MissingDependencyError
from /Users/simeonwillbanks/Code/html-pipeline/lib/html/pipeline/markdown_filter.rb:4:in `rescue in <top (required)>'
[3] pry(main)> require "github/markdown"
LoadError: cannot load such file -- github/markdown
from /usr/local/var/rbenv/versions/2.3.0/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'

Solution

Resolve the exception constant by using the full namespace.

~/Code/html-pipeline add-namespace-to-missing-deps-raise
❯ git diff
diff --git a/lib/html/pipeline/markdown_filter.rb b/lib/html/pipeline/markdown_filter.rb
index 94a820a..b16dfc8 100644
--- a/lib/html/pipeline/markdown_filter.rb
+++ b/lib/html/pipeline/markdown_filter.rb
@@ -1,7 +1,7 @@
 begin
   require "github/markdown"
 rescue LoadError => _
-  raise MissingDependencyError, "Missing dependency 'github-markdown' for MarkdownFilter. See README.md for details."
+  raise HTML::Pipeline::MissingDependencyError, "Missing dependency 'github-markdown' for MarkdownFilter. See README.md for detai
 end

 module HTML

~/Code/html-pipeline add-namespace-to-missing-deps-raise*
❯ irb -I lib
[1] pry(main)> require 'html/pipeline'
=> true
[2] pry(main)> filter = HTML::Pipeline::MarkdownFilter.new("Hi **world**!")
HTML::Pipeline::MissingDependencyError: Missing dependency 'github-markdown' for MarkdownFilter. See README.md for details.
from /Users/simeonwillbanks/Code/html-pipeline/lib/html/pipeline/markdown_filter.rb:4:in `rescue in <top (required)>'

/cc @parkr @jch

[simeonwillbanks]

@parkr Thanks for the original Pull Request! Sorry we missed this in code review. 😊

[parkr]

@simeonwillbanks Thanks for catching this! Apologies for the dud.

[jch]

@simeonwillbanks 🙇 thanks for catching my mistake. @parkr no need to apologize, I should've been more thorough with the review.

@simeonwillbanks would you be open to releasing a patch release?

[simeonwillbanks]

@jch prepping release...

[simeonwillbanks]

@jch @parkr released!

https://rubygems.org/gems/html-pipeline/versions/2.2.4

[parkr]

Thank you, @simeonwillbanks! 🎉

[jch]

🎉

On Sun, Jan 17, 2016 at 2:47 PM, Parker Moore [email protected]
wrote:

Thank you, @simeonwillbanks https://github.com/simeonwillbanks! [image:
🎉]

—
Reply to this email directly or view it on GitHub
#243 (comment).

Jerry Cheung
GitHub https://github.com/jch

[simeonwillbanks]

😉