explicitly depend upon pygments.rb

[kbrock]

fixes #235

To reproduce, change the Gemfile from:

    gem "github-linguist",  "~> 2.10",  :require => false

to

    gem "github-linguist",  "> 2.10",  :require => false

and bundle update

I tried not requiring 'pygments.rb', and using defined?, but it looked like nothing worked without including the requirement.

I updated the README as well.

[simeonwillbanks]

👍

[JuanitoFatas]

github-linguist < 4 don't need to include this dependency, right?

How about we add a comment to inform this?

# github-linguist version > 4 need to explicitly include pygments.rb,
# see https://github.com/jch/html-pipeline/issues/235
# gem "pygments.rb",                  :require => false

[kbrock]

@JuanitoFatas Thanks - any other thoughts?

[barraq]

@kbrock @jch do we still need github-linguist? the newest version totally removed its need (lexer is gone). In one of my project I overrode SyntaxHighlightFilter to only use Pygments:

class HTML::Pipeline
  # Patch SyntaxHighlightFilter (@todo provide fix)
  class SyntaxHighlightFilter < Filter
    def lexer_for(lang)
      Pygments::Lexer[lang]
    end
  end
end

This works like a charm ;)

[kbrock]

Think this is no longer needed