Fix for calling mention_link_filter with only one argument #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the 4th argument for
HTML::Pipeline::MentionFilter#mention_link_filter
,username_pattern
, is required, even though args 2 and 3 are optional.I believe this is a regression introduced in #157.
I copied the default argument format of
mentioned_logins_in
to default the final argument toUsernamePattern
and added a test (themention_link_filter
had no tests previously AFAIK).Before:
After
/cc @brittballard