Render irc and ircs URLs #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently there was discussion of this in #39 previously. |
|
status on this? |
|
Hate to "bump" but... bump? I'd really like this merged. |
|
Seems sane to me, thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An instance of what this would look like can be seen in the README.rst for python-gssapi in the "Get Involved" section: the channel listing should be a link, as can be seen in the source.
Markup already handles this correctly; I have also tested with pandoc, which rendered it correctly as well. The problem seems to be that
irc://is not an acceptable URL prefix.The convention of using
irc://URLs is not new; Mozilla, mIRC, and others have been using this for some time.