MentionFilter#link_to_mentioned_user: Replace String introspection with Regexp match #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `last` requires ActiveSupport and applications may not have required 'active_support/core_ext/string' - Instead of extracting the last character and matching against that character, refactor the Regexp, so it tests the last character of the `base_url`
|
@simeonwillbanks thank you! 👍 |
jch
added a commit
that referenced
this pull request
Jan 21, 2015
…rt-bug MentionFilter#link_to_mentioned_user: Replace String introspection with Regexp match
|
🍻 |
|
😄 Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#167 introduced a subtle bug by relying upon
ActiveSupport'sString#last. The tests passed because the test helper requiresactive_support/core_ext/string.Not all applications will require
ActiveSupport'sString, and the extension seemed heavy for theMentionFilter.This Pull Request improves the existing
Regexp, so theMentionFilterdoesn't needActiveSupport'sString.Commit Message:
lastrequires ActiveSupport and applications may not have required'active_support/core_ext/string'
character, refactor the Regexp, so it tests the last character of
the
base_url