Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the github filter chain? #16

Merged
merged 1 commit into from
Nov 27, 2012
Merged

What is the github filter chain? #16

merged 1 commit into from
Nov 27, 2012

Conversation

jch
Copy link
Contributor

@jch jch commented Nov 27, 2012

Would be great to see an explicit example of what filter chain you guys use, not sure I would want to use it directly, but I think it would be a rather informative starting point.

Also, thanks for sharing, definitely an awesomely helpful tool for making nice with user content.

@jch
Copy link
Contributor

jch commented Nov 27, 2012

@geemus the pipelines we use include a bunch of configuration code that's not really interesting to look at. I added an examples section that gives a general idea of more useful pipelines, but if you have suggestions on better examples, I'd love to include them. Just shoot over pull request ;)

jch added a commit that referenced this pull request Nov 27, 2012
What is the github filter chain?
@jch jch merged commit 36edb30 into master Nov 27, 2012
@geemus
Copy link
Author

geemus commented Nov 27, 2012

@jch - Sounds good. I felt like the previous example explained how to use it, but fell a bit short of feeling like concrete/real usage, so these definitely help clarify a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants