Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with relaxed test dependencies #155

Closed
wants to merge 5 commits into from
Closed

Conversation

jch
Copy link
Contributor

@jch jch commented Oct 2, 2014

This PR always chooses the latest gem for a given ruby version for testing.

Jerry Cheung added 2 commits October 2, 2014 15:50
always choose the latest gem for a given ruby version for testing
@jch
Copy link
Contributor Author

jch commented Oct 2, 2014

Hmmm not fantastic. It might be better to experiment with different gemfiles within travis.

@simeonwillbanks
Copy link
Contributor

Relaxing the dependencies is a win for users, so their applications have more freedom. However, all the gems require a specific configuration for the tests to pass.

👍 multiple gemfiles for two reasons:

  1. Passing build
  2. Documentation around known working dependencies

@jch jch mentioned this pull request Oct 5, 2014
@jch
Copy link
Contributor Author

jch commented Oct 6, 2014

Quick update, it looks like we get some failures with the latest gemoji (2.1.0)

  1) Failure:
HTML::Pipeline::EmojiFilterTest#test_uri_encoding [/Users/jch/projects/html-pipeline/test/html/pipeline/emoji_filter_test.rb:21]:
Expected /https:\/\/foo\.com\/emoji\/%2B1\.png/ to match "https://foo.com/emoji/unicode/1f44d.png".


  2) Failure:
HTML::Pipeline::EmojiFilterTest#test_custom_asset_path [/Users/jch/projects/html-pipeline/test/html/pipeline/emoji_filter_test.rb:34]:
Expected /https:\/\/foo\.com\/%2B1\.png/ to match "https://foo.com/unicode/1f44d.png".


@jch jch added this to the 2.0 milestone Oct 7, 2014
@jch
Copy link
Contributor Author

jch commented Oct 7, 2014

#129 may have some hints.

@jch
Copy link
Contributor Author

jch commented Oct 7, 2014

#159 fixes gemoji related CI failures.

@jch
Copy link
Contributor Author

jch commented Dec 3, 2014

Closing this because it doesn't feel right to try to couple our tests to external dependencies. A better approach would be to extract out filters that depend on external dependencies to their own gems.

@simeonwillbanks
Copy link
Contributor

👍 own gems. Maybe we open a new issue to discuss?

@jch jch closed this Jan 21, 2015
@jch jch deleted the relax-test-dependencies branch January 21, 2015 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants