<tt> tags are not skipped by EmojiFilter #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this? |
moskvax
force-pushed
the
emojifilter-skip-tt-tags
branch
from
97af38b
to
4aef895
Compare
moskvax
force-pushed
the
emojifilter-skip-tt-tags
branch
from
4aef895
to
76cefbc
Compare
|
🍻 |
jch
added a commit
that referenced
this pull request
Oct 5, 2014
<tt> tags are not skipped by EmojiFilter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest2html command in github/markup outputs HTML4, so it wraps rst inline literals with
<tt>instead of<code>. The emoji filter doesn't recognize<tt>as a tag that contains literal content, and emoji are substituted where they shouldn't be.Toy example: https://github.com/moskvax/test/tree/master/test
Real example: https://github.com/mpv-player/mpv/blob/master/DOCS/man/vf.rst