Search for text nodes on DocumentFragments without root tags

[Razer6]

Hi @jch

I came up with a second solution for fixing #133. It simply tries a second search for text nodes, if the original search doesn't find any node. Since the second search is only invoked, if the first one doesn't find any node, performance should not change much.

[jch]

Nice idea! I like the idea of this. I'll look over it more closely when I
get back to a keyboard

On Sunday, September 14, 2014, Robert Schilling [email protected]
wrote:

Hi @jch https://github.com/jch

I came up with a second solution for fixing #133
#133. It simply tries a
second search for text nodes, if the original search doesn't find any node.
Since the second search is only invoked, if the first one doesn't find any

node, performance should not change much.

You can merge this Pull Request by running

git pull https://github.com/Razer6/html-pipeline search_text_nodes

Or view, comment on, or merge it at:

#146
Commit Summary

• Search for text nodes on DocumentFragments without root tags

File Changes

• M lib/html/pipeline/@mention_filter.rb
  https://github.com/jch/html-pipeline/pull/146/files#diff-0 (4)
• M lib/html/pipeline/emoji_filter.rb
  https://github.com/jch/html-pipeline/pull/146/files#diff-1 (2)
• M lib/html/pipeline/filter.rb
  https://github.com/jch/html-pipeline/pull/146/files#diff-2 (7)
• M test/html/pipeline/emoji_filter_test.rb
  https://github.com/jch/html-pipeline/pull/146/files#diff-3 (6)

Patch Links:

• https://github.com/jch/html-pipeline/pull/146.patch
• https://github.com/jch/html-pipeline/pull/146.diff

—
Reply to this email directly or view it on GitHub
#146.

Jerry Cheung
GitHub https://github.com/jch

[jch]

🍻