Generalize https filter take 2

[simeonwillbanks]

• Fixes De-github https filter #123
• Restarts Generalize https filter #124
• Refactored to use Minitest

Thanks for your contribution @rymohr!

@jch this is ready for review.

[jch]

Thanks all!

[bkeepers]

I just tried to upgrade github to the latest release and this is causing issues. This change requires that we set base_url to "http://github.com", but that breaks some of our other URL generation which assumes base_url is the HTTPS url.

[jch]

@bkeepers we could choose another variable name to avoid this conflict. What do you think of http_url? Where is the conflict coming from?

[bkeepers]

we could choose another variable name to avoid this conflict. What do you think of http_url?

I was thinking the same. We could fall back to base_url too: context[:http_url] || context[:base_url].

Where is the conflict coming from?

We use base_url in our MentionFilter and CommitMentionFilter for generating links to user profiles and commits.

[jch]

@bkeepers 👍 to a fallback for compatibility. I think it'd be good to document context variables that are shared between variables to prevent conflicts also. I can start on that after we fix this issue.