Remove RUBY_VERSION conditionals from gemspec #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the useless conditionals added in ae1f3c8 since gemspec is turned into a static one at gem publish time, so the version constraints will be adjusted to whatever Ruby version the gem was *published* with, not the one that will eventually run the gem. If someone is still running Ruby 1.8 or 1.9.2, it's their responsibility to adjust their project's Gemfile to prevent Nokogiri or Active Support upgrading to an incompatible version.
|
Fixed CI problems and merged. Patch release coming soon after I clean out a few more things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the useless conditionals added in ae1f3c8 since gemspec is turned into a static one at gem publish time, so the version constraints will be adjusted to whatever Ruby version the gem was published with, not the one that will eventually run the gem.
If someone is still running Ruby 1.8 or 1.9.2, it's their responsibility to adjust their project's Gemfile to prevent Nokogiri or Active Support upgrading to an incompatible version.
/cc @jch