Adding support to supply the path to the emoji sprite in the emoji pipeline #122
Conversation
| if context[:asset_path] | ||
| context[:asset_path].gsub(":file_name", "#{::CGI.escape(name)}.png") | ||
| else | ||
| "emoji/#{::CGI.escape(name)}.png" |
There was a problem hiding this comment.
Please use File.join instead of /. Thanks!
File.join("emoji", "#{::CGI.escape(name)}.png")
| @@ -12,6 +12,7 @@ class Pipeline | |||
| # | |||
| # Context: | |||
| # :asset_root (required) - base url to link to emoji sprite | |||
| # :asset_path (optional) - url path to link to emoji sprite. :file_name can be used as a placeholder for the sprite file name. | |||
There was a problem hiding this comment.
Maybe explain here that if left unspecified, the asset path will be "emoji/:file_name"
|
👍 nice change. One of us will be happy to merge this and cut a new release after the small requested changes above |
|
Thanks, guys! I'll get those changes up shortly. |
|
Looking good 👏 I'll |
Adding support to supply the path to the emoji sprite in the emoji pipeline
|
Sweet, thanks for the help! One thing I noticed... You are using File.join to join URI segments, but File.join uses the OS's file system delimiter which could be different from '/', especially if someone is developing on Windows. URI has URI.join but it doesn't work for relative URI's or protocal-less hosts like "//example.com". Not sure if this is worth worrying about, but if it is I could take a crack at it. |
|
@bradly don't know much about that because that was before I started maintaining this project. Would love to hear your findings if you do look into it though. ;) |
|
I'll continue with the release... |
This was helpful for us, so just seeing if there is interest merging back into master. Let me know if you have any feedback. Thanks!