Better error notification on missing linguist dependency?

[gjtorikian]

Chalk this up to RTFM, but with a simple filter like this

HTML::Pipeline.new [
          HTML::Pipeline::MarkdownFilter,
          HTML::Pipeline::SyntaxHighlightFilter
        ]

I kept getting the help rails app to crash:

SystemExit in Help/articles#show

Showing /Users/garentorikian/github/help/app/views/help/articles/_article.html.erb where line #22 raised:

exit
Extracted source (around line #22):

Finally, after looking at the logs, I found: You need to install linguist before using the SyntaxHighlightFilter. See README.md for details.

Not sure if this error can be raised in the browser itself, but it'd be nice. Also not sure if this'll be fixed by #28 anyway.

[jch]

Sucks that the error message was cryptic from your log 😦

Even though it's a gem full of html utilities, this gem doesn't make any assumption about where you're using it. The best we can do is print the error message to stderr.

[gjtorikian]

What about replacing $stderr.puts with a Raise?

This is what text_filter.rb does, and because of it, I could see its error on the browser/app.

[jch]

That sounds good to me. Brain fart on my part for not thinking of that. Do you want to send a PR my way for that? I'll bump the gem version after merging that.

[gjtorikian]

Sure, gimme a minute.

On Wed, Feb 6, 2013 at 5:13 PM, Jerry Cheung [email protected]:

That sounds good to me. Brain fart on my part for not thinking of that. Do
you want to send a PR my way for that? I'll bump the gem version after
merging that.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/36#issuecomment-13216080.

[jch]

Thanks for the speedy pull! I've released 0.0.8 with your changes http://rubygems.org/gems/html-pipeline/versions/0.0.8