-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EmailReplyParser is undefined #107
Comments
@foca good catch. It looks like we forgot to specify an external dependency to https://github.com/github/email_reply_parser. Would you be interested in writing a pull request for this? P.S. How've you been? I haven't talked to you in forever, hope everything's going well 😉 |
Ah, awesome. Didn't see that was open sourced! I'll send a PR soon :) I've been great. How about you? I'm trying to figure out how to sneak a visit to the west coast and catch up with everyone :D miss you guys! ^_^ On Mon, Feb 3, 2014 at 7:53 PM, Jerry Cheung [email protected]
|
@foca For your convenience, I can send a Pull Request. We just refactored dependency management, and it's fresh in my head. Let me know! 😄 |
@simeonwillbanks thanks! But it's no problem, it was simple enough to do :) |
@foca Very cool. Thanks for the help! 🤘 |
I might be missing some dependency, but the
EmailReplyFilter
references anEmailReplyParser
constant which is not defined in the gem, at all :)Can't remember if this is something that was there in github/github or maybe github/html-pipeline? But it should proooobably be here. Or maybe it's EmailReplyFilter that shouldn't be :P
The text was updated successfully, but these errors were encountered: