You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Sorry, was mostly interested in the escape_utils bump, but the gemspec isn't restricting so we can manage that app-side. This isn't a big deal, my bad.
98fc8dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this version bump be released to rubygems.org?
98fc8dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jch did the nokogiri stuff make it in or do we need to cut another release?
98fc8dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, was mostly interested in the escape_utils bump, but the gemspec isn't restricting so we can manage that app-side. This isn't a big deal, my bad.
98fc8dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nokogiri fix made it in but requires nokogiri >= 1.5.6 to work properly. We should probably rev the html-pipeline gemspec to specify that.
98fc8dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty good current status:
#40 (comment)