Skip to content

Commit

Permalink
raise MissingDependencyError instead of aborting on missing dependency
Browse files Browse the repository at this point in the history
Reverts a0acb69
Fixes #240
  • Loading branch information
parkr committed Jan 14, 2016
1 parent 5bf0502 commit 3edf0c9
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 9 deletions.
2 changes: 2 additions & 0 deletions lib/html/pipeline.rb
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ class Pipeline
autoload :TextileFilter, 'html/pipeline/textile_filter'
autoload :TableOfContentsFilter, 'html/pipeline/toc_filter'
autoload :TextFilter, 'html/pipeline/text_filter'

MissingDependencyError = Class.new(LoadError)

# Our DOM implementation.
DocumentFragment = Nokogiri::HTML::DocumentFragment
Expand Down
2 changes: 1 addition & 1 deletion lib/html/pipeline/autolink_filter.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
begin
require "rinku"
rescue LoadError => _
abort "Missing dependency 'rinku' for AutolinkFilter. See README.md for details."
raise MissingDependencyError, "Missing dependency 'rinku' for AutolinkFilter. See README.md for details."
end

module HTML
Expand Down
4 changes: 2 additions & 2 deletions lib/html/pipeline/email_reply_filter.rb
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
begin
require "escape_utils"
rescue LoadError => _
abort "Missing dependency 'escape_utils' for EmailReplyFilter. See README.md for details."
raise MissingDependencyError, "Missing dependency 'escape_utils' for EmailReplyFilter. See README.md for details."
end

begin
require "email_reply_parser"
rescue LoadError => _
abort "Missing dependency 'email_reply_parser' for EmailReplyFilter. See README.md for details."
raise MissingDependencyError, "Missing dependency 'email_reply_parser' for EmailReplyFilter. See README.md for details."
end

module HTML
Expand Down
2 changes: 1 addition & 1 deletion lib/html/pipeline/emoji_filter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
begin
require "gemoji"
rescue LoadError => _
abort "Missing dependency 'gemoji' for EmojiFilter. See README.md for details."
raise MissingDependencyError, "Missing dependency 'gemoji' for EmojiFilter. See README.md for details."
end

module HTML
Expand Down
2 changes: 1 addition & 1 deletion lib/html/pipeline/markdown_filter.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
begin
require "github/markdown"
rescue LoadError => _
abort "Missing dependency 'github-markdown' for MarkdownFilter. See README.md for details."
raise MissingDependencyError, "Missing dependency 'github-markdown' for MarkdownFilter. See README.md for details."
end

module HTML
Expand Down
2 changes: 1 addition & 1 deletion lib/html/pipeline/plain_text_input_filter.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
begin
require "escape_utils"
rescue LoadError => _
abort "Missing dependency 'escape_utils' for PlainTextInputFilter. See README.md for details."
raise MissingDependencyError, "Missing dependency 'escape_utils' for PlainTextInputFilter. See README.md for details."
end

module HTML
Expand Down
2 changes: 1 addition & 1 deletion lib/html/pipeline/sanitization_filter.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
begin
require "sanitize"
rescue LoadError => _
abort "Missing dependency 'sanitize' for SanitizationFilter. See README.md for details."
raise MissingDependencyError, "Missing dependency 'sanitize' for SanitizationFilter. See README.md for details."
end

module HTML
Expand Down
2 changes: 1 addition & 1 deletion lib/html/pipeline/syntax_highlight_filter.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
begin
require "linguist"
rescue LoadError => _
abort "Missing dependency 'github-linguist' for SyntaxHighlightFilter. See README.md for details."
raise MissingDependencyError, "Missing dependency 'github-linguist' for SyntaxHighlightFilter. See README.md for details."
end

module HTML
Expand Down
2 changes: 1 addition & 1 deletion lib/html/pipeline/textile_filter.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
begin
require "redcloth"
rescue LoadError => _
abort "Missing dependency 'RedCloth' for TextileFilter. See README.md for details."
raise MissingDependencyError, "Missing dependency 'RedCloth' for TextileFilter. See README.md for details."
end

module HTML
Expand Down

0 comments on commit 3edf0c9

Please sign in to comment.