[lets-rust] Get CI for Linux/macOS working #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was too curious and explored this messily. Still need to install dev tools on Windows or something?
The trick was:
chdir, just stay put wherever mini_portile puts us; and,c-apias astaticlibonly; wasn't required for the Mac build to work (see 9565657 build logs), maybe the build prefers.ato.dylib, but on Linux it's like "hey where's mylibcomrak_ffi.so".If this looks good to you, I say we merge kivikakk/comrak@c-api-staticlib and then squash this all into #185 (minus the branch name change).