Merge pull request #257 from noraj/patch-1

fix front_matter_delimiter type

.gitignore

@@ -34,8 +34,11 @@ build/
 
 # for a library or gem, you might want to ignore these files since the code is
 # intended to run in multiple environments; otherwise, check them in:
-# .ruby-version
-# .ruby-gemset
+# as rbenv
+.ruby-version
+.ruby-gemset
+# or ASDF-VM
+.tool-versions
 
 # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
 .rvmrc

ext/commonmarker/src/options.rs

@@ -104,7 +104,11 @@ fn iterate_extension_options(comrak_options: &mut ComrakOptions, options_hash: R
                     comrak_options.extension.description_lists = TryConvert::try_convert(value)?;
                 }
                 Ok(Cow::Borrowed(EXTENSION_FRONT_MATTER_DELIMITER)) => {
-                    comrak_options.extension.front_matter_delimiter = try_convert_string(value);
+                    if let Some(option) = try_convert_string(value) {
+                        if !option.is_empty() {
+                            comrak_options.extension.front_matter_delimiter = Some(option);
+                        }
+                    }
                 }
                 Ok(Cow::Borrowed(EXTENSION_SHORTCODES)) => {
                     comrak_options.extension.shortcodes = TryConvert::try_convert(value)?;

lib/commonmarker/config.rb

@@ -26,7 +26,7 @@ module Config
         header_ids: "",
         footnotes: false,
         description_lists: false,
-        front_matter_delimiter: nil,
+        front_matter_delimiter: "",
         shortcodes: true,
       },
       format: [:html].freeze,

lib/commonmarker/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Commonmarker
-  VERSION = "1.0.0.pre10"
+  VERSION = "1.0.0.pre11"
 end

test/frontmatter_test.rb

@@ -14,4 +14,13 @@ def test_frontmatter_does_not_interfere_with_codeblock
 
     assert_equal(expected, Commonmarker.to_html(md, plugins: nil))
   end
+
+  def test_frontmatter_custom_delimiter
+    md = "---\nyaml: true\nage: 42\n---\n# Title 1"
+    expected = <<~HTML
+      <h1>Title 1</h1>
+    HTML
+
+    assert_equal(expected, Commonmarker.to_html(md, options: { extension: { front_matter_delimiter: "---" } }))
+  end
 end