Skip to content

Commit

Permalink
fix(node-gtk): Add disconnect gobject signal method to SIGNAL_METHOD_…
Browse files Browse the repository at this point in the history
…NAMES_GENERAL, see #126
  • Loading branch information
JumpLink committed Jun 5, 2023
1 parent 9f1f8f6 commit 640460f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/lib/src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ export const PACKAGE_KEYWORDS = (packageName: string, environment: Environment)

export const GENERIC_NAMES: string[] = ['A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'K']

export const SIGNAL_METHOD_NAMES_GENERAL: string[] = ['connect', 'emit']
export const SIGNAL_METHOD_NAMES_GJS: string[] = ['connect_after', 'emit', 'disconnect']
export const SIGNAL_METHOD_NAMES_GENERAL: string[] = ['connect', 'emit', 'disconnect']
export const SIGNAL_METHOD_NAMES_GJS: string[] = ['connect_after', 'emit']
export const SIGNAL_METHOD_NAMES_NODE: string[] = ['after', 'on', 'once', 'off']
export const SIGNAL_METHOD_NAMES = (env: Environment) => {
if (env === 'node') {
Expand Down
2 changes: 1 addition & 1 deletion packages/lib/src/types/ts-signal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { TsMethod, TsCallback, TsCallbackInterface } from './index.js'
* Holds the data to generate a function in/for Typescript for `GirSignal`
*/
export interface TsSignal extends TsCallback {
/** Signal functions like `connect`, `connect_after`, `disconnect` and `emit` on Gjs or `connect`, `after`, `on`, `once`, `off` and `emit` an node-gtk */
/** Signal functions like `connect`, `connect_after`, `disconnect` and `emit` on Gjs or `connect`, `disconnect`, `after`, `on`, `once`, `off` and `emit` an node-gtk */
tsMethods: TsMethod[]

/** Signal overloads, used in `ConflictResolver` */
Expand Down

0 comments on commit 640460f

Please sign in to comment.