Various fixes to resolve barchart style inconsistencies #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a couple changes to resolve UI inconsistencies I found when using this library. The overall goal is to have these items fixed upstream so I don't have to include a modified version of the
barchart.go
file in my project source.Proposed changes
Commit 1
The percent text value always starts from the bar center position.
While this looks great when working with one character
Data
values (as pictured in the termui example) it looks awkward when dealing with long values since items greater thanBarWidth / 2
end up bleeding into the next bar. The position should be calculated based on the character length andBarWidth
size available.Commit 2
The bar is not completely rendered when
Data
values< 2%
exist. I'm not sure this is intentional but the chart should maintain consistent sizing in regard to the bar width even if the value is1%
or less.Before
After