[WIP] podman: add new cgroup mode conmon-delegated #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a new mode cgroup mode conmon-delegated. When running under systemd there is no need to create yet another cgroup for the container. With conmon-delegated the current cgroup will be split in two sub cgroups: - supervisor - container The supervisor cgroup will hold conmon and the podman process, while the container cgroup is used by the OCI runtime (using the cgroupfs backend). Closes: containers#6400 Depends on: containers/crun#409 Signed-off-by: Giuseppe Scrivano <[email protected]>
Not sure why we need another function to do cgroups in utils - we have pkg/cgroups oci_conmon_linux already deals with moving conmon...
A lot of the conmonDelegated exceptions seem to deal with manufacturing a cgroupParent when needed, instead of just setting the cgroupParent we already have
goochjj
force-pushed
the
conmon-delegate-cgv1
branch
from
1147665 to
f67ceec
Compare
giuseppe
force-pushed
the
conmon-delegate
branch
6 times, most recently
from
ac92674 to
6ee5f74
Compare
giuseppe
pushed a commit
that referenced
this pull request
Jun 30, 2020
Friendly amendment for pr 6751
giuseppe
pushed a commit
that referenced
this pull request
Jan 24, 2022
Signed-off-by: Daniel J Walsh <[email protected]>
giuseppe
pushed a commit
that referenced
this pull request
Jan 24, 2022
Fix #2 for compat commit handling of --changes
giuseppe
pushed a commit
that referenced
this pull request
Aug 7, 2023
* Use vfkit command line assembly * Inject ignition file into guest using http over vsock * Ready notification through use of vsock [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My testing w.r.t. containers#6666