Skip to content

Conversation

@laktak
Copy link
Contributor

@laktak laktak commented Oct 23, 2025

This Pull Request fixes/closes #2510.

It changes the following:

  • adds a --file cli flag to open the files tab with the given file already selected

I followed the checklist:

@laktak laktak force-pushed the sel_file_from_cli branch from 76f6471 to de87a44 Compare October 23, 2025 20:16
@laktak
Copy link
Contributor Author

laktak commented Oct 23, 2025

I don't do Rust very often so I'm quite happy that it works ;)

However while I followed the guidelines as best as I could, I hope you can help with this error from clippy:

error: this function has too many arguments (8/7)
   --> src/main.rs:214:1

@laktak laktak force-pushed the sel_file_from_cli branch from de87a44 to 419c902 Compare October 23, 2025 20:41
@laktak
Copy link
Contributor Author

laktak commented Oct 23, 2025

Is that OK?

#[allow(clippy::too_many_arguments)]
fn run_app(

@laktak laktak force-pushed the sel_file_from_cli branch from 419c902 to 4937126 Compare October 23, 2025 21:00
sender_app: Sender<AsyncAppNotification>,
input: Input,
theme: Theme,
select_file: Option<PathBuf>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets just pass the whole CliArgs in here as one param combining selected_file and repo - this should also solve the too many args clippy warning you got

@extrawurst extrawurst added this to the v0.28 milestone Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flag to automatically open at file

2 participants