Skip to content

Conversation

@Fatpandac
Copy link
Contributor

@Fatpandac Fatpandac commented Jan 20, 2025

This Pull Request fixes/closes #2404.

It changes the following:

  • support choosing checkout branch method when status is not empty
  • add .editorconfig file

image

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

Copy link
Collaborator

@extrawurst extrawurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! I left the first round of feedbacks

@Fatpandac Fatpandac requested a review from extrawurst January 29, 2025 04:08
Copy link

@dotslashdan dotslashdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, apologies for the intrusion. i have come across this repo just now and have been poking around. i hope you don't mind but i've left a few comments and questions i have, but don't feel obligated to reply

@extrawurst extrawurst requested review from cruessler and removed request for dotslashdan October 22, 2025 09:25
@extrawurst extrawurst removed their request for review October 28, 2025 16:04
@extrawurst extrawurst added this to the v0.28 milestone Oct 28, 2025
Copy link
Collaborator

@extrawurst extrawurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@extrawurst
Copy link
Collaborator

extrawurst commented Oct 28, 2025

I have looked at this a while ago extensively. Would like a second pair of eyes @cruessler - please give it a go aswell locally, not just by code-review so we do not miss potential regressions. give me a merge_ready when you think its good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

checkout branch stashing/reapplying changes

3 participants