Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default value for GITLAB_INSTANCE_URI #330

Merged
merged 2 commits into from
Sep 5, 2018

Conversation

AgusRdz
Copy link
Contributor

@AgusRdz AgusRdz commented Aug 30, 2018

Description

This commit solve the issue when a user try to sync your GitLab repositories,

Motivation and context

Currently GitLab is thorowing an error while a user try sync your repositories, this is caused because the env helper isn't working properly on app/Classes/GitLab, also the function tplRepository into this file is trying to access to $repo->public but this property not exists and now is using $repo->visibility instead, visibility property is an string not a boolean as some users suggests in others PR.

fixes #329

How has this been tested?

Performed several tests manually with a fresh repo installation and via postman to debug the API response.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@AgusRdz AgusRdz mentioned this pull request Aug 30, 2018
@renatomarinho renatomarinho merged commit 2b57261 into gitscrum-team:master Sep 5, 2018
This was referenced Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

repositories not loaded
2 participants