Added default value for GITLAB_INSTANCE_URI #330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit solve the issue when a user try to sync your GitLab repositories,
Motivation and context
Currently GitLab is thorowing an error while a user try sync your repositories, this is caused because the
env
helper isn't working properly onapp/Classes/GitLab
, also the functiontplRepository
into this file is trying to access to$repo->public
but this property not exists and now is using$repo->visibility
instead,visibility
property is an string not a boolean as some users suggests in others PR.fixes #329
How has this been tested?
Performed several tests manually with a fresh repo installation and via postman to debug the API response.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist: