Add new build scripts #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Furisto
force-pushed
the
fo/build-scripts
branch
from
0d44757 to
7541195
Compare
Furisto
force-pushed
the
fo/build-scripts
branch
2 times, most recently
from
a7b545a to
405a4a8
Compare
|
@princerachit PTAL |
kylos101
reviewed
Mar 16, 2022
Furisto
force-pushed
the
fo/build-scripts
branch
2 times, most recently
from
3aba6de to
ad002b5
Compare
|
@kylos101 PTAL |
Furisto
force-pushed
the
fo/build-scripts
branch
2 times, most recently
from
1c8bee9 to
282feb5
Compare
kylos101
force-pushed
the
fo/build-scripts
branch
from
282feb5 to
918ff3e
Compare
kylos101
approved these changes
Mar 17, 2022
kylos101
force-pushed
the
fo/build-scripts
branch
from
918ff3e to
26c320a
Compare
Combo tests fail, which creates confusion, let's make the script single purpose -- chunks only.
kylos101
reviewed
Mar 17, 2022
|
|
||
| function build_and_combine() { | ||
| dazzle build ${REPO} -v --chunked-without-hash && dazzle build ${REPO} -v && dazzle combine ${REPO} --all -v | ||
| function build_chunks() { |
There was a problem hiding this comment.
Renamed from build_and_combine
|
Hey there, I removed Now we have one script for each purpose.
@Furisto @princerachit LMKWYT, I've tested and seems to be working well. You're welcome to merge if you approve, but, since I've made changes would like you to peek. |
|
Fine by me, but will wait for @princerachit opinion as well. |
@princerachit is out today on holiday, let's circle back in a follow-up PR, if needed. 😃 I cleaned up the docs in a81f0e7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new build scripts for building images. With this we have three scripts:
Also updated yq because that was a really old version
Related Issue(s)
Fixes #763
How to test
Release Notes
Documentation
Already done by updating the CONTRIBUTING.md