Skip to content

Conversation

@aledbf
Copy link
Member

@aledbf aledbf commented Aug 1, 2021

No description provided.

Test workspace-full
Update dev image
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2021

⚠️ Hew reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harfmul.

@roboquat roboquat added size/S and removed size/XS labels Aug 1, 2021
Fix gosimple S1017
@roboquat
Copy link
Contributor

roboquat commented Aug 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aledbf
To complete the pull request process, please assign csweichel after the PR has been reviewed.
You can assign the PR to them by writing /assign @csweichel in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2021

⚠️ Hew reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harfmul.

@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #5029 (a105f88) into main (75d49f7) will increase coverage by 31.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5029       +/-   ##
=========================================
+ Coverage      0   31.04%   +31.04%     
=========================================
  Files         0      104      +104     
  Lines         0    19755    +19755     
=========================================
+ Hits          0     6133     +6133     
- Misses        0    13097    +13097     
- Partials      0      525      +525     
Flag Coverage Δ
components-blobserve-app 28.92% <ø> (?)
components-content-service-app 14.47% <ø> (?)
components-content-service-lib 14.47% <ø> (?)
components-ee-ws-scheduler-app 62.51% <ø> (?)
components-gitpod-cli-app 9.74% <ø> (?)
components-image-builder-app 34.44% <ø> (?)
components-image-builder-mk3-app 6.53% <ø> (?)
components-local-app-api-go-lib ∅ <ø> (?)
components-local-app-app-darwin ∅ <ø> (?)
components-local-app-app-linux ∅ <ø> (?)
components-local-app-app-windows ∅ <ø> (?)
components-registry-facade-app 11.58% <0.00%> (?)
components-registry-facade-lib 11.58% <0.00%> (?)
components-supervisor-app 37.19% <ø> (?)
components-workspacekit-app 7.69% <ø> (?)
components-ws-daemon-app 23.02% <ø> (?)
components-ws-daemon-nsinsider-app ∅ <ø> (?)
components-ws-manager-app 36.32% <ø> (?)
components-ws-proxy-app 67.13% <ø> (?)
dev-loadgen-app ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/registry-facade/pkg/registry/registry.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/config.go 32.50% <0.00%> (ø)
components/content-service/pkg/storage/noop.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/annotations.go 66.66% <0.00%> (ø)
components/gitpod-cli/cmd/root.go 0.00% <0.00%> (ø)
components/supervisor/pkg/terminal/service.go 29.09% <0.00%> (ø)
components/ws-proxy/pkg/proxy/infoprovider.go 50.34% <0.00%> (ø)
components/ws-proxy/pkg/proxy/cookies.go 78.57% <0.00%> (ø)
components/ee/ws-scheduler/pkg/scaler/time.go 66.66% <0.00%> (ø)
components/ws-manager/pkg/manager/imagespec.go 0.00% <0.00%> (ø)
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75d49f7...a105f88. Read the comment docs.

@aledbf aledbf requested a review from jankeromnes August 1, 2021 04:30
@aledbf
Copy link
Member Author

aledbf commented Aug 1, 2021

@aledbf
Copy link
Member Author

aledbf commented Aug 1, 2021

/hold

@aledbf aledbf closed this Aug 10, 2021
@aledbf aledbf deleted the aledbf/test-image branch August 16, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants