Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize recently added commit diff api url #4906

Merged
merged 1 commit into from
Aug 29, 2013
Merged

Standardize recently added commit diff api url #4906

merged 1 commit into from
Aug 29, 2013

Conversation

alexvh
Copy link
Contributor

@alexvh alexvh commented Aug 26, 2013

Use "/commits/:sha/diff" as opposed to "/commit/:sha", keeping in line with existing api urls (e.g. "/commits/:sha/blob", "/projects/:id", etc.)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.18%) when pulling 499cb7e9e1f620ab2932bacb239f9e016b46aa70 on alexvh:standardize_diff_api_url into e897520 on gitlabhq:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-13.23%) when pulling 499cb7e9e1f620ab2932bacb239f9e016b46aa70 on alexvh:standardize_diff_api_url into e897520 on gitlabhq:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-13.17%) when pulling 499cb7e9e1f620ab2932bacb239f9e016b46aa70 on alexvh:standardize_diff_api_url into e897520 on gitlabhq:master.

@dzaporozhets
Copy link
Contributor

I think we better change /commits/:sha/blob to /blob/:sha

@alexvh
Copy link
Contributor Author

alexvh commented Aug 26, 2013

I agree blob should be changed.
How about I do the following?:
[] Change blob to /blob (presumably, leaving existing path working as to not break existing users)
[] Add a 'get /commits/:sha' for retrieving a commit's info (e.g. author, date, etc.)
[*] Leave the commit diff api changed to '/commits/:sha/diff'

@dzaporozhets
Copy link
Contributor

@alexvh +1 for this changes

@alexvh
Standardize commit diff api url, change blob api url, add get single …
59f428d 
…commit

Use "/commits/:sha/diff" as opposed to "/commit/:sha", keeping in line
with existing api urls (e.g. "/projects/:id", etc.)

Fix 500 error resulting from a diff api call with an invalid commit hash

Move "/commits/:sha/blob" to "/blobs/:sha", leaving the old path for
backwards compatibility.

Add ability to get a single commit via "/commits/:sha"
@alexvh
Copy link
Contributor Author

alexvh commented Aug 28, 2013

Updated. Commit message contains details of changes.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 59f428d on alexvh:standardize_diff_api_url into 777456b on gitlabhq:master.

@dzaporozhets
Copy link
Contributor

Looks good. Thank you

dzaporozhets added a commit that referenced this pull request Aug 29, 2013
@dzaporozhets
Merge pull request #4906 from alexvh/standardize_diff_api_url
079d3a5 
Standardize recently added commit diff api url
@dzaporozhets dzaporozhets merged commit 079d3a5 into gitlabhq:master Aug 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexvh @coveralls @dzaporozhets