-
Notifications
You must be signed in to change notification settings - Fork 486
Add project Template list #1127 #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
10c8512
to
9d79920
Compare
* The token is revoked and a new one which will expire in one week is created to replace it. | ||
* Only working with GitLab 16.0 and above. | ||
* | ||
*ProjectTemplate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a wired addition to the javadoc
List<ProjectTemplate> projectTemplates = unmarshalResourceList(ProjectTemplate.class, "project-templates.json"); | ||
assertTrue(compareJson(projectTemplates, "project-templates.json")); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add a similar test for ProjectTemplateDetail.java
get(Response.Status.OK, queryParams, "projects", getProjectIdOrPath(projectIdOrPath), "iterations"); | ||
return (response.readEntity(new GenericType<List<Iteration>>() {})); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadoc is missing here.
return (response.readEntity(new GenericType<List<ProjectTemplate>>() {})); | ||
} | ||
|
||
public ProjectTemplateDetail getProjectTemplate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadoc is missing here.
9d79920
to
f78d450
Compare
Thanks @jmini, should be ok now :) |
No description provided.