Skip to content

Conversation

otary
Copy link
Contributor

@otary otary commented Dec 10, 2024

add RepositoryApi.compare(Object projectIdOrPath, String from, String to, Object fromProjectId, boolean straight)

* @return a CompareResults containing the results of the comparison
* @throws GitLabApiException if any exception occurs
*/
public CompareResults compare(Object projectIdOrPath, String from, String to, boolean straight)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this method should be deprecated, now that we have the one accepting more parameters.

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look almost good to me. Thank you for this contribution.

@jmini jmini merged commit 569c51c into gitlab4j:main Dec 24, 2024
2 checks passed
@jmini
Copy link
Collaborator

jmini commented Dec 24, 2024

🎉 thank you for this contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants